chore: upgrade vite-plus to 0.2.1#25
Draft
fengmk2 wants to merge 2 commits into
Draft
Conversation
v0.2.1 consumes upstream Vitest directly, so the @voidzero-dev/vite-plus-test wrapper is removed and vitest now comes in transitively through vite-plus. - vite-plus: 0.1.20 -> 0.2.1 - vite override -> npm:@voidzero-dev/vite-plus-core@0.2.1 - pin upstream vitest 4.1.9 (was the wrapper alias) and bump @vitest/coverage-v8 to 4.1.9 - add @vitest/browser-playwright 4.1.9, now an optional peer of vite-plus, used by the nuxt browser test project - drop the wrapper-based vitest override
oxlint 1.70 (bundled in vite-plus 0.2.1) flags import names that collide with prop names. Alias the internal imports so they no longer shadow the public prop names; behaviour is unchanged. - Input/Base.vue: noCorrect/noPasswordManager imports -> *Attrs aliases - Tooltip/Base.vue: offset middleware import -> offsetMiddleware
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors imports in the Input and Tooltip base components to use clearer aliases (such as 'noCorrectAttrs', 'noPasswordManagerAttrs', and 'offsetMiddleware') to avoid naming conflicts. Additionally, it updates project dependencies, upgrading 'vite-plus' to '0.2.1', reverting 'vitest' from a custom fork to the official '4.1.9' release, and adding '@vitest/browser-playwright'. Lockfile and workspace configurations have been updated accordingly. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
fengmk2
commented
Jun 18, 2026
| @@ -1,5 +1,8 @@ | |||
| <script setup lang="ts"> | |||
| import { noCorrect, noPasswordManager } from '~/utils/input' | |||
Owner
Author
There was a problem hiding this comment.
× [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'noCorrect'. May cause name collision in script or template tag.
╭─[app/components/Input/Base.vue:2:10]
1 │ <script setup lang="ts">
2 │ import { noCorrect, noPasswordManager } from '~/utils/input'
· ─────────
3 │
╰────
× [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'noPasswordManager'. May cause name collision in script or template tag.
╭─[app/components/Input/Base.vue:2:21]
1 │ <script setup lang="ts">
2 │ import { noCorrect, noPasswordManager } from '~/utils/input'
· ─────────────────
3 │
╰────
fengmk2
commented
Jun 18, 2026
| import type { HTMLAttributes } from 'vue' | ||
| import type { Placement, Strategy } from '@floating-ui/vue' | ||
| import { autoUpdate, flip, offset, shift, useFloating } from '@floating-ui/vue' | ||
| import { autoUpdate, flip, offset as offsetMiddleware, shift, useFloating } from '@floating-ui/vue' |
Owner
Author
There was a problem hiding this comment.
× [vue(no-dupe-keys)](https://oxc.rs/docs/guide/usage/linter/rules/vue/no-dupe-keys.html): Duplicate key 'offset'. May cause name collision in script or template tag.
╭─[app/components/Tooltip/Base.vue:4:28]
3 │ import type { Placement, Strategy } from '@floating-ui/vue'
4 │ import { autoUpdate, flip, offset, shift, useFloating } from '@floating-ui/vue'
· ──────
5 │
╰────
📊 Dependency Size ChangesWarning This PR adds 12.1 MB of new dependencies, which exceeds the threshold of 200 kB.
Total size change: 12.1 MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upgrade Vite+ (
vp) from v0.1.x to v0.2.1. v0.2.1 consumes upstream Vitest directly: the@voidzero-dev/vite-plus-testwrapper is removed andvitestnow comes in transitively throughvite-plus.Changes
vite-plus:0.1.20->0.2.1viteoverride ->npm:@voidzero-dev/vite-plus-core@0.2.1(still required, kept in lockstep)vitest, plus the@vitest/coverage-v8provider), so upstream vitest is pinned to the bundled4.1.9:vitest: wrapper alias ->4.1.9@vitest/coverage-v8:4.1.6->4.1.9@vitest/browser-playwright@4.1.9(now an optional peer of vite-plus, needed by thenuxtbrowser test project)vitestoverride frompnpm-workspace.yamlvue/no-dupe-keyserrors newly surfaced by the bundled oxlint 1.70 (import names that shadowed prop names), via internal import aliases. Behaviour unchanged.Verification
@voidzero-dev/vite-plus-testreference remains outsidenode_modulesvitest@4.1.9(no duplicate copies)vp test: 135 files, 2724 passed / 5 skipped (nativeRUN v4.1.9banner)vp check: passes (0 errors)